Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial migration script to include TCR tables & custom query tables #2462

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

m-goggins
Copy link
Collaborator

@m-goggins m-goggins commented Aug 29, 2024

PULL REQUEST

Summary

Adds the initial migration SQL script for Flyway to create the TCR tables and the custom query tables. This should allow Brandon to implement Flyway.

Related Issue

Fixes #2437

Acceptance Criteria

Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@m-goggins m-goggins marked this pull request as ready for review August 29, 2024 17:34
Copy link
Collaborator

@bamader bamader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if we don't need the FOREIGN KEY tag!

Copy link
Collaborator

@DanPaseltiner DanPaseltiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create indexes on all primary and foreign keys? We learned previously that PG doesn't do this automatically and join performance will suffer without them.

@m-goggins
Copy link
Collaborator Author

Good point, @DanPaseltiner! I added all the indexes for primary and foreign keys

Copy link
Collaborator

@robertandremitchell robertandremitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@m-goggins m-goggins added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit 4af8605 Aug 29, 2024
10 checks passed
@m-goggins m-goggins deleted the 2437/tefca-migration-script-1 branch August 29, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration #1: Port TCR SQLite DB to Postgres
4 participants